Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposer selection upgrade and proposer set voting protocol in fallback case #633

Closed
wants to merge 2 commits into from
Closed

Proposer selection upgrade and proposer set voting protocol in fallback case #633

wants to merge 2 commits into from

Conversation

drewstone
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • In an effort to simplify operations of the bridge and handle the propser set voting protocol seamlessly, we make the restriction that proposers can only be active validators.
  • We use the proposers to watch the chain in the event we force_change_authorities.
  • If the force_change_authorities extrinsic is called, we have the proposers sign the Vote with their ECDSA keys and gossip similarly to how we gossip misbehaviours
  • We store these votes for any relayer to grab and apply.

Reference issue to close (if applicable)

Closes

@drewstone drewstone changed the title Modify proposers to only come from validator set Proposer selection upgrade and proposer set voting protocol in fallback case Jun 9, 2023
@drewstone drewstone requested a review from 1xstj June 9, 2023 20:46
@drewstone drewstone linked an issue Jun 9, 2023 that may be closed by this pull request
[CHECKLIST] Trigger emergency fallback when stalling is detected #628
Open
7 tasks
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 43.30% and project coverage change: -2.24 ⚠️

Comparison is base (efb068b) 19.28% compared to head (e28294a) 17.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   19.28%   17.04%   -2.24%     
==========================================
  Files          75       77       +2     
  Lines        4981     5548     +567     
==========================================
- Hits          960      945      -15     
- Misses       4021     4603     +582
Impacted Files Coverage Δ
pallets/dkg-proposals/src/benchmarking.rs 0.00% <ø> (ø)
pallets/dkg-proposals/src/weights.rs 0.00% <ø> (ø)
pallets/dkg-metadata/src/lib.rs 23.26% <6.90%> (-0.75%) ⬇️
dkg-runtime-primitives/src/traits.rs 14.29% <20.00%> (-19.04%) ⬇️
pallets/dkg-proposals/src/lib.rs 73.52% <60.66%> (-4.97%) ⬇️
dkg-runtime-primitives/src/lib.rs 36.00% <100.00%> (ø)

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drewstone drewstone closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1xstj 1xstj Awaiting requested review from 1xstj 1xstj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHECKLIST] Trigger emergency fallback when stalling is detected
2 participants
@drewstone @codecov-commenter